Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set provider value comparer when configuring value conversion #27942

Merged
merged 2 commits into from
May 5, 2022
Merged

Allow to set provider value comparer when configuring value conversion #27942

merged 2 commits into from
May 5, 2022

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented May 3, 2022 •
edited
Loading

  • Use client value comparer as provider value comparer if possible
    • The client value comparer will not be used if the model type is a nullable value type since we need the types to match exactly and the provider type is never nullable
  • Fix some API issues
  • Remove some unused code

Fixes #27738
Fixes #27850
Fixes #27791
Part of #27588

@AndriySvyryd
Allow to set provider value comparer when configuring value conversion
1ec8f89 
Use client value comparer as provider value comparer if possible
The client value comparer will not be used if the model type is a nullable value type
Fix some API issues
Remove some unused code

Fixes #27738
Fixes #27850
Fixes #27791
Part of #27588
@AndriySvyryd AndriySvyryd requested review from ajcvickers and a team May 3, 2022 19:11
@AndriySvyryd AndriySvyryd merged commit 3ea4803 into main May 5, 2022
@AndriySvyryd AndriySvyryd deleted the Issue27738 branch May 5, 2022 21:41
@ajcvickers ajcvickers mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndriySvyryd @ajcvickers